Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(backend): await for events to be written #1266

Merged
merged 11 commits into from
Jul 2, 2024
Merged

fix(backend): await for events to be written #1266

merged 11 commits into from
Jul 2, 2024

Conversation

Mogge
Copy link
Contributor

@Mogge Mogge commented Jun 26, 2024

🍰 Pullrequest

Unit tests for newsletter subscription and contact are flaky, because it is not waited until the event is written to the db.

Five runs did not have any problems

Issues

  • None

Todo

  • None

@Mogge Mogge self-assigned this Jun 26, 2024
@Mogge Mogge added bug Something isn't working test service:backend labels Jun 26, 2024
Elweyn
Elweyn previously approved these changes Jun 26, 2024
Elweyn
Elweyn previously approved these changes Jul 2, 2024
Copy link
Member

@Elweyn Elweyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes.

@Mogge Mogge enabled auto-merge (squash) July 2, 2024 14:08
@Mogge Mogge merged commit fd6c35d into master Jul 2, 2024
76 checks passed
@mahula mahula deleted the await-for-events branch July 25, 2024 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working service:backend test
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

🐛 [Bug] Flaky backend Unit Test: NewsletterSubscriptionResolver.spec.ts
2 participants