Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(frontend): avatar reactive #1784

Merged
merged 2 commits into from
Aug 15, 2024
Merged

fix(frontend): avatar reactive #1784

merged 2 commits into from
Aug 15, 2024

Conversation

Mogge
Copy link
Contributor

@Mogge Mogge commented Aug 15, 2024

🍰 Pullrequest

Before:
image

After:
image

See as well the unit tests. The wrapper had to be remounted as the avatar was not reactive.

Issues

  • None

Todo

  • None

@Mogge Mogge self-assigned this Aug 15, 2024
@Mogge Mogge requested a review from Bettelstab August 15, 2024 11:48
@Mogge Mogge added bug Something isn't working service:frontend labels Aug 15, 2024
@Mogge Mogge enabled auto-merge (squash) August 15, 2024 11:51
@Mogge Mogge merged commit 0991c91 into master Aug 15, 2024
33 checks passed
@ulfgebhardt ulfgebhardt deleted the fix-non-reactive-avatar branch September 12, 2024 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Bettelstab Bettelstab Bettelstab approved these changes

Assignees

@Mogge Mogge

Labels
bug Something isn't working service:frontend
Projects
Dreammall.earth
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Mogge @Bettelstab