Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(backend): logging events #244

Merged
merged 16 commits into from
Feb 19, 2024
Merged

feat(backend): logging events #244

merged 16 commits into from
Feb 19, 2024

Conversation

ulfgebhardt
Copy link
Member

@ulfgebhardt ulfgebhardt commented Feb 14, 2024 •
edited
Loading

🍰 Pullrequest

logging events

Issues

Todo

  • Test fixes
  • Test for events to be written to database

@ulfgebhardt ulfgebhardt self-assigned this Feb 14, 2024
@ulfgebhardt ulfgebhardt added feature New feature or request service:backend labels Feb 14, 2024
@ulfgebhardt ulfgebhardt changed the title [WIP] feat(backend): logging events feat(backend): logging events Feb 15, 2024
Elweyn
Elweyn reviewed Feb 15, 2024
View reviewed changes
Copy link
Member

@Elweyn Elweyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good for me, lets just talk about the opened discussions.

backend/src/graphql/inputs/ContactFormInput.ts Outdated Show resolved Hide resolved
backend/src/graphql/inputs/SubscribeToNewsletterInput.ts Outdated Show resolved Hide resolved
backend/src/graphql/resolvers/ContactFormResolver.ts Show resolved Hide resolved
Mogge
Mogge requested changes Feb 19, 2024
View reviewed changes
Copy link
Contributor

@Mogge Mogge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some small improvement to a test

backend/src/graphql/resolvers/ContactFormResolver.spec.ts Outdated Show resolved Hide resolved
backend/test/helpers.ts Show resolved Hide resolved
@ulfgebhardt ulfgebhardt requested a review from Mogge February 19, 2024 13:27
@ulfgebhardt ulfgebhardt merged commit 614a9d9 into master Feb 19, 2024
22 checks passed
@ulfgebhardt ulfgebhardt deleted the logging-events branch February 22, 2024 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Elweyn Elweyn Elweyn left review comments

@Mogge Mogge Mogge approved these changes

Assignees

@ulfgebhardt ulfgebhardt

Labels
feature New feature or request service:backend
Projects
Dreammall.earth
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ulfgebhardt @Mogge @Elweyn