feat(other): sso dreammall flows #350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ulfgebhardt
added
feature
Elweyn
approved these changes
Mar 19, 2024
There was a problem hiding this comment.
Seems to work! Just a small "bug" when the enrollment process is done and we come back on the localhost:3000 page their is still the Sign In | Sign Up buttons even still we are loged in, what makes it feel a bit "buggy" but after clicking on sign in we have the normal process!
Nice job
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🍰 Pullrequest
This PR implements the following flows:
New users enrolling are created in the
Dreammall UsersGroup.For local development the enrollment without email is used - this flow must not be used on production (if email confirmation is wished for).
There is two known problems: password complexity is not checked for and the user is redirected to the presenter after register, but not logged in, tho logged in in Authentik.
Issues
Todo