Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(presenter): improve sign in/up buttons #383

Merged
merged 9 commits into from
Mar 27, 2024
Merged

Conversation

maeckes1
Copy link
Contributor

🍰 Pullrequest

Improves UI issues with sign in/up buttons in the headermenu.

Design:
image

Video:
image

Mobile:
image

Issues

Todo

  • None

@maeckes1 maeckes1 requested review from ulfgebhardt and Elweyn March 22, 2024 14:52
@maeckes1 maeckes1 self-assigned this Mar 22, 2024
@maeckes1 maeckes1 added bug Something isn't working refactor design labels Mar 22, 2024
@ulfgebhardt
Copy link
Member

Can we hide the buttons when the video plays? Or fit it better in the design? Maybe talk with @Hardy-Hart-am-Start about it.

Copy link
Member

@ulfgebhardt ulfgebhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like this merged in light of #398

@maeckes1 maeckes1 marked this pull request as ready for review March 27, 2024 07:47
@maeckes1 maeckes1 merged commit aa26b05 into master Mar 27, 2024
41 checks passed
@ulfgebhardt ulfgebhardt deleted the 353-fix-buttons branch March 27, 2024 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working design refactor
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

🐛 [Bug] Fix Signin/Signup Buttons in Menu
2 participants