Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(presenter): translate page title with i18n #397

Merged
merged 14 commits into from
Mar 26, 2024
Merged

feat(presenter): translate page title with i18n #397

merged 14 commits into from
Mar 26, 2024

Conversation

Elweyn
Copy link
Member

@Elweyn Elweyn commented Mar 26, 2024

🍰 Pullrequest

Issues

  • None

Todo

  • None

@Elweyn Elweyn self-assigned this Mar 26, 2024
@Elweyn Elweyn linked an issue Mar 26, 2024 that may be closed by this pull request
🚀 [Feature] Implement page title translation and vike language #208
Closed
ulfgebhardt
ulfgebhardt reviewed Mar 26, 2024
View reviewed changes
Copy link
Member

@ulfgebhardt ulfgebhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks to be very close to the target already (only judging the title stuff). I assume when the first PR is merged this one can be merged quickly after - there seem only minor things to be fixed.

presenter/.env.dist Outdated Show resolved Hide resolved
presenter/renderer/utils.ts Outdated Show resolved Hide resolved
presenter/src/components/language/LanguageSelector.test.ts Outdated Show resolved Hide resolved
presenter/src/pages/_error/+title.ts Outdated Show resolved Hide resolved
Tirokk
Tirokk previously requested changes Mar 26, 2024
View reviewed changes
presenter/src/pages/index/+title.ts Outdated Show resolved Hide resolved
presenter/src/pages/impressum/+title.ts Outdated Show resolved Hide resolved
presenter/src/pages/datenschutz/+title.ts Outdated Show resolved Hide resolved
presenter/src/pages/auth/+title.ts Outdated Show resolved Hide resolved
presenter/src/pages/optin/+title.ts Outdated Show resolved Hide resolved
presenter/src/pages/silent-refresh/+title.ts Outdated Show resolved Hide resolved
ulfgebhardt
ulfgebhardt previously approved these changes Mar 26, 2024
View reviewed changes
@Elweyn Elweyn dismissed Tirokk’s stale review March 26, 2024 13:01

Done changes

@Elweyn Elweyn merged commit 182d930 into master Mar 26, 2024
41 checks passed
@Elweyn Elweyn deleted the 208-feat-page-title-translate branch March 26, 2024 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ulfgebhardt ulfgebhardt ulfgebhardt approved these changes

@Tirokk Tirokk Tirokk left review comments

Assignees

@Elweyn Elweyn

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🚀 [Feature] Implement page title translation and vike language
3 participants
@Elweyn @ulfgebhardt @Tirokk