add git workflow support #19
Conversation
|
Hi @cav71 , thanks for you effort, but I think you are overengineering this a bit. There is no need to do all the parsing of arguments, etc. in Python, since the PyRun Makefile already takes care of these things. The only part where this could be useful is for figuring out the SSL variable on various platforms, but this is often not needed, since the defaults in the Makefile should work most of the time. The reason I added this variable is because we used to ship our own SSL libs (as part of egenix-pyopenssl) and so I wanted to enable PyRun to use those. It's really more important to get the main workflow framework set up, so that builds on multiple platforms are possible. I was thinking of reusing parts of the machinery that https://github.com/indygreg/python-build-standalone is using: running builds in docker images for the different platforms, but without doing cross compiles and limiting the number of variants significantly compared to what Greg is doing. What was your motivation to start putting the Makefile logic into a Python make.py ? |
|
Thanks for the feedback. The key take into this pr is to create the workflow support (eg. anything under
That is only for testing, aka display something: it can be replaced. I was thinking also that it could easily replace the Makefile as it is naturally multi platform, but that again wasn't necessary and as it is it just dumps variables and show the workflow runs correctly. I'm ok to close the PR if that doesn't suit the project! Thanks again. |
|
Oh, I don't want to discourage you. However, the make.py file is not really something I'm looking for. The workflows themselves are great as skeleton and a good start, so if you could remove the make.py this could go in. |
|
I'm not discouraged, believe me. I've removed the |
Initial ground work to enable CD/CI support