Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[doc] rearrange and improve README #17

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

line-o
Copy link
Member

@line-o line-o commented Nov 19, 2020

closes #14

Copy link
Contributor

@adamretter adamretter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, a good start. Just needs a little fine-tuning.

1. `git clone https://github.com/exist-db/exist-xqts-runner.git`
2. `cd exist-xqts-runner`
3. `sbt compile`
In your local checkout of eXistdb run:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This only needs to be done if you want to use custom artifacts. Otherwise they are pulled from Maven Central. I think these steps needed for compiling and installing eXist-db artifacts need to be labelled as Optional.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, yes and no. I would argue that running it against a development version is the common use-case.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would even argue that the version target should be promoted to a command line argument.


### Packaging the Application from Compiled Source
* If you require a standard Jar file for some purpose you can run `sbt package`, which will generate `target/scala-2.13/exist-xqts-runner_2.13-1.0.0.jar`.
- `target/scala-2.13/exist-xqts-runner-assembly-1.0.0.jar`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Previously the bit about the --help flag came before this. I think we still need to talk about --help otherwise users won't know what to run.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In my experience the assembled jar was the only useful output.
Maybe it is better to give the standard jar its own section further below along with the --help flag. It would be cool if you would add that section as you are likely the best one to describe what you would use it for.

Copy link
Member

@dizzzz dizzzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These additions really help me.... I forget about the HEAD thing etc.
Also ti would be good to know how to delete the cached test/HEAD fileset

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] error running specs using sbt "run"
3 participants