-
-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feature] Functions for listing hash providers and algorithms and specifying them when hashing #8
base: main
Are you sure you want to change the base?
Conversation
4bcfc1f
to
49aadb3
Compare
This seems like a valuable PR. +1 to merging it or at least advancing discussion. |
@claudius108 During this week's Community Call, the group took a look at this and thought it looked quite useful. What are your thoughts? Also, everyone is excited to have SHA256RSA, which @nsincaglia told us about—when you're able ;) |
SHA256RSA works already, I will push the changes after Nick Sincaglia will confirm also this. As to the listing functions, in the new version of specification I added such functions, but more comprehensive. But you can keep these, if you want, it is up to you. |
I was able to confirm that the SHA256RSA encryption algorithm produced a verified output and therefore I concluded the algorithm was working properly.
Nick
|
Thanks, Claudius, could you point me to the URL with the version of the spec that contains the functions you mentioned? |
I ask because maybe there's a way to bring this PR in line with the spec. Are there any implementations of your spec's version of the functions in question? |
49aadb3
to
e20cbdd
Compare
@claudius108 Where can we find the latest version of the spec please? |
what to do with this PR? |
@adamretter can this be rebased? |
@line-o Possibly... I can try... but it is from 2008. So I am not sure what has been incorporated in the mean-time! let me try... |
Seems there is a corresponding PR to resolve here - expath/crypto-java#5 |
e20cbdd
to
486f532
Compare
@line-o Okay, as requested I have rebased this. It requires that expath/crypto-java#5 is merged and a release of that published, but otherwise I believe this is ready to land. |
@adamretter Do you know which (if any) spec these functions are intended to align with? I ask because as described in #41 I'd like to nail down the relationship between the spec(s) and the eXist implementation. |
p.s. I think my merge of #45 caused a new conflict. |
@joewiz To be honest, I don't. This pull request is from 2018. It may be that I just recognised that these auxiliary functions may be useful, or that I followed a spec at that time. I am afraid I don't recall... |
…cifying them when hashing
486f532
to
35dac8d
Compare
Requires - expath/crypto-java#5
Adds the functions:
crypto:hash-providers() as xs:string*
crypto:hash-algorithms($provider-name as xs:string) as xs:string*
crypto:hash-algorithms() as map(xs:string, xs:string*)
crypto:hash($data as item(), $algorithm as xs:string, $encoding as xs:string, $provider as xs:string)