-
-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
minor enhancements #801
minor enhancements #801
Conversation
@duncdrum Could you explain the purpose of the "exception fixture"? Looking elsewhere in the commit, I don't see where it's used. |
@joewiz sure the fixtures are normally used in the unit test of the custom mocha interface to exist's generator-exist/test/mock_xqs.js Lines 6 to 9 in c4585f6
I added the xml in the hope to have an idea for how to use it in a future test, that doesn't involve debugging/fixing exists, mochas, and my own code. My current approach can't handle mocha encountering errors of this type, much like xqsuite can't handle NPEs. Ultimately users get more descriptive errors now, and the CI fails when it should. Designing a working test for this will be a lot of work for very little actual gain. |
invalid testsuites no longer produce cryptic failures see eXist-db#800
address @joewiz review comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the info on fixtures! That's a neat capability. The PR looks good to me.
🎉 This PR is included in version 6.0.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
found some oddities while looking into #800. This makes error handling for faulty test-suites more robust, and adds an alternative means of using a local copy when developing.
There is a regression from upstream with
npm.Install
that still needs more investigation.see #649