Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minor enhancements #801

Merged
merged 10 commits into from
Apr 27, 2022
Merged

minor enhancements #801

merged 10 commits into from
Apr 27, 2022

Conversation

duncdrum
Copy link
Collaborator

@duncdrum duncdrum commented Apr 26, 2022

found some oddities while looking into #800. This makes error handling for faulty test-suites more robust, and adds an alternative means of using a local copy when developing.

There is a regression from upstream with npm.Install that still needs more investigation.

see #649

@duncdrum duncdrum changed the title Fix 800 minor enhancemets Apr 26, 2022
@duncdrum duncdrum changed the title minor enhancemets minor enhancements Apr 26, 2022
@duncdrum duncdrum requested a review from a team April 26, 2022 13:59
@joewiz
Copy link
Member

joewiz commented Apr 26, 2022

@duncdrum Could you explain the purpose of the "exception fixture"? Looking elsewhere in the commit, I don't see where it's used.

@joewiz
Copy link
Member

joewiz commented Apr 26, 2022

@duncdrum A minor thing, not about this PR per se: I just noticed that view.xql wasn't included in the cleanup of XQuery file extensions in #701. You consider slipping that into this PR too - as another minor enhancement?

@duncdrum
Copy link
Collaborator Author

duncdrum commented Apr 26, 2022

@joewiz sure the fixtures are normally used in the unit test of the custom mocha interface to exist's xqsuite. they are all based on real responses and corner cases observed in the wild.

const monoCase = require('./fixtures/mono-case.json')
const multiCase = require('./fixtures/multi-case.json')
const multiSuite = require('./fixtures/multi-suite.json')

I added the xml in the hope to have an idea for how to use it in a future test, that doesn't involve debugging/fixing exists, mochas, and my own code. My current approach can't handle mocha encountering errors of this type, much like xqsuite can't handle NPEs.

Ultimately users get more descriptive errors now, and the CI fails when it should. Designing a working test for this will be a lot of work for very little actual gain.

Copy link
Member

@joewiz joewiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the info on fixtures! That's a neat capability. The PR looks good to me.

@joewiz joewiz merged commit c8ae1a7 into eXist-db:main Apr 27, 2022
@github-actions
Copy link

🎉 This PR is included in version 6.0.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants