Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐞 fix(cypress): bump to v10 #841

Merged
merged 4 commits into from
Jul 5, 2022
Merged

🐞 fix(cypress): bump to v10 #841

merged 4 commits into from
Jul 5, 2022

Conversation

duncdrum
Copy link
Collaborator

@duncdrum duncdrum commented Jul 5, 2022 •
edited
Loading

BREAKING CHANGE: update config files for cypress 10

presence of old config file will result in broken testsuites

see #842
close #833
close #800

@duncdrum
🐞 fix(cypress): bump to v10
a327feb 
BREAKING CHANGE: update config files for cypress 10

presence of old config file will result in broken testsuites

close #833
close #800
@duncdrum duncdrum added bug CI / Testing Issues related to CI and testing setup labels Jul 5, 2022
@duncdrum duncdrum requested a review from a team July 5, 2022 13:21
line-o
line-o reviewed Jul 5, 2022
View reviewed changes
Copy link
Member

@line-o line-o left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but I believe supportFile path needs changing

generators/app/templates/specs/cypress.config.js Outdated Show resolved Hide resolved
duncdrum added 3 commits July 5, 2022 16:14
@duncdrum
🐞 fix(cypress): address review
97e451f 
typo on config
@duncdrum
📃 docs(readme): adjust trees
fdba1ed 
make yo@4 explicit

see #833
@duncdrum
🎈 perf(npm): more robust npm
890fe8a 
see yeoman/generator#1294

yo@5 is still not handling this well
line-o
line-o approved these changes Jul 5, 2022
View reviewed changes
Copy link
Member

@line-o line-o left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sad that yo@5 makes issues, I am still in favour of going this step forward

@duncdrum duncdrum merged commit b7f65b4 into main Jul 5, 2022
@duncdrum duncdrum deleted the upgrade-cypres branch July 5, 2022 21:06
@github-actions
Copy link

github-actions bot commented Jul 5, 2022

🎉 This PR is included in version 8.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@line-o line-o line-o approved these changes

Assignees
No one assigned
Labels
bug CI / Testing Issues related to CI and testing setup released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

upgrade cypress config file to v10 CI fails for new repo [BUG]
2 participants
@duncdrum @line-o