[core] service client use datainfo #1876
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…needed (downward compatibility to v5)
…ementation naming to public API)
…m SMethodMon ugly logic added to make new service server implementation compatible to old v5 API (where AddDescription may be called any time separately) python API extended with datatype information for pub/sub and server/client
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| Logging::Log(log_level_warning, "CServiceServerImpl::AddMethodCallback: Method already exists, updating callback: " + method_); | ||
| Logging::Log(log_level_warning, "CServiceServerImpl::SetMethodCallback: Method already exists, updating attributes and callback: " + method_); | ||
|
|
||
| #if 0 // this is how it should look like if we do not use the old type and descriptor fields |
There was a problem hiding this comment.
warning: preprocessor condition is always 'false', consider removing both the condition and its contents [readability-avoid-unconditional-preprocessor-if]
#if 0 // this is how it should look like if we do not use the old type and descriptor fields
^| // method name | ||
| method.method.mname = method_; | ||
|
|
||
| #if 0 // this is how it should look like if we do not use the old type and descriptor fields |
There was a problem hiding this comment.
warning: preprocessor condition is always 'false', consider removing both the condition and its contents [readability-avoid-unconditional-preprocessor-if]
#if 0 // this is how it should look like if we do not use the old type and descriptor fields
^
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
1. Provide/use new
SDataTypeInformationfields in client and server registration (old fields still supported)2. Introduce new method callback function signature for
eCAL::v6::CServiceServerOld v5 signature:
New v6 signature: