refactor!: Change configuration and devices files format to YAML #445
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lenny-goodell
suggested changes
Mar 27, 2023
cmd/res/configuration.yaml
Outdated
Comment on lines
12
to
15
| Service: | ||
| Port: 59901 | ||
| StartupMsg: device modbus started |
There was a problem hiding this comment.
Suggested change
| Service: | |
| Port: 59901 | |
| StartupMsg: device modbus started | |
| Service: | |
| Host: localhost | |
| Port: 59901 | |
| StartupMsg: device modbus started |
| @@ -0,0 +1,56 @@ | |||
| # Pre-define Devices | |||
| DeviceList: | |||
There was a problem hiding this comment.
Same issue here as in the other PR about fields needing to be camelCase.
BREAKING CHANGE: Configuration and devices files are now in YAML format closes issue edgexfoundry#444 Signed-off-by: Valina Li <valina.li@intel.com>
Signed-off-by: Valina Li <valina.li@intel.com>
Signed-off-by: Valina Li <valina.li@intel.com>
Signed-off-by: Valina Li <valina.li@intel.com>
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #445 +/- ##
=======================================
Coverage 42.52% 42.52%
=======================================
Files 6 6
Lines 555 555
=======================================
Hits 236 236
Misses 276 276
Partials 43 43 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
lenny-goodell
suggested changes
Mar 28, 2023
Signed-off-by: Valina Li <valina.li@intel.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: Configuration and devices files are now in YAML format
closes issue #444
If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/device-modbus-go/blob/main/.github/Contributing.md
PR Checklist
Please check if your PR fulfills the following requirements:
BREAKING CHANGE:describing the break)Testing Instructions
device-modbus-go$ make tidy
device-modbus-go$ make build
device-modbus-go$ make test
device-modbus-go$ make docker
edgex-compose$ make pull
edgex-compose/compose-builder$ make run no-secty
device-modbus-go/cmd$ ./device-modbus -cp -o
verified that device-modbus-go log has below printout without error
New Dependency Instructions (If applicable)