Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: should use paddingMessageFormatter on ConsoleTransport options #92

Merged
merged 1 commit into from
Oct 16, 2023

Conversation

AmazingCaddy
Copy link
Contributor

Checklist
  • npm test passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)
Description of change

@AmazingCaddy
Copy link
Contributor Author

fix typo included by PR #83

@codecov
Copy link

codecov bot commented Oct 16, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (a054bca) 98.72% compared to head (26a3660) 98.72%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master      #92   +/-   ##
=======================================
  Coverage   98.72%   98.72%           
=======================================
  Files          14       14           
  Lines        1338     1338           
  Branches      222      222           
=======================================
  Hits         1321     1321           
  Misses         17       17           
Files Coverage Δ
lib/egg/logger.js 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fengmk2 fengmk2 changed the title fix: fix typo - wrong paddingMessageFormatter key and value fix: should use paddingMessageFormatter on ConsoleTransport options Oct 16, 2023
@fengmk2 fengmk2 added the bug label Oct 16, 2023
Copy link
Member

@fengmk2 fengmk2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@fengmk2 fengmk2 merged commit 32ec755 into eggjs:master Oct 16, 2023
13 checks passed
fengmk2 pushed a commit that referenced this pull request Oct 16, 2023
[skip ci]

## [3.4.1](v3.4.0...v3.4.1) (2023-10-16)

### Bug Fixes

* should use paddingMessageFormatter on ConsoleTransport options ([#92](#92)) ([32ec755](32ec755))
@fengmk2
Copy link
Member

fengmk2 commented Oct 16, 2023

@AmazingCaddy 感谢!帮助我们发现了一个隐藏问题。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants