feat: adds strict mode support #1
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eiriktsarpalis
force-pushed
the
remove-json-schema-mapper
branch
from
88cbfc7 to
df45a59
Compare
baywet
force-pushed
the
feat/strict-mode
branch
from
fa2cde4 to
c800b20
Compare
baywet
commented
Dec 9, 2024
baywet
commented
Dec 9, 2024
eiriktsarpalis
force-pushed
the
remove-json-schema-mapper
branch
from
823155c to
33ebf16
Compare
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
…pping Signed-off-by: Vincent Biret <vibiret@microsoft.com>
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
baywet
force-pushed
the
feat/strict-mode
branch
from
20d4c40 to
0ae128c
Compare
baywet
commented
Dec 9, 2024
baywet
commented
Dec 9, 2024
| var jsonObject = parsedJson.AsObject(); | ||
| foreach (var forbiddenPropertyName in forbiddenPropertyNames) | ||
| { | ||
| jsonObject.Remove(forbiddenPropertyName); |
There was a problem hiding this comment.
this is where I'm doing the forbidden keywords cleanup, might want to be recursive in case we have those on the request body.
more context microsoft#9807 (comment)
|
re-opened here microsoft#9924 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related microsoft#9786
this PR should NOT be merged, it's just intending to ease up comparisons until microsoft#9807 gets merged.
I'll open another PR to upstream once 9807 gets merged
pending questions: