TBS: drop and recreate badger db after exceeding storage limit for TTL time #15106
+327
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request does not have a backport label. Could you fix it @carsonip? 🙏
|
|
|
mergify
bot
added
the
backport-8.x
carsonip
added
backport-8.16
carsonip
changed the title
carsonip
commented
Jan 2, 2025
carsonip
commented
Jan 2, 2025
| } | ||
|
|
||
| func (s *ManagedReadWriter) WriteTraceEvent(traceID, id string, event *modelpb.APMEvent, opts WriterOpts) error { | ||
| s.sm.mu.RLock() |
There was a problem hiding this comment.
TODO: not sure if it should RLock and wait for the swap, or just fail right away with TryRLock to avoid blocking ingestion.
1pkg
reviewed
Jan 3, 2025
1pkg
reviewed
Jan 3, 2025
1pkg
reviewed
Jan 3, 2025
2 tasks
|
|
This was referenced Jan 3, 2025
carsonip
force-pushed
the
tbs-recover-from-storage-limit-exceeded-rm-db
branch
from
8e65516 to
9605745
Compare
carsonip
changed the title
carsonip
force-pushed
the
tbs-recover-from-storage-limit-exceeded-rm-db
branch
from
9605745 to
1e4d5b3
Compare
2 tasks
carsonip
commented
Jan 3, 2025
| now := time.Now() | ||
| if firstExceeded.IsZero() { | ||
| firstExceeded = now | ||
| s.logger.Warnf("badger db size has exceeded storage limit; db will be dropped and recreated if problem persists for `sampling.tail.ttl` (%s)", ttl.String()) |
There was a problem hiding this comment.
TODO: maybe report badger db size in this log line as well
1pkg
previously approved these changes
Jan 4, 2025
1pkg
reviewed
Jan 4, 2025
| return len(filenames) == 0 | ||
| }, 10*time.Second, 500*time.Millisecond, filenames) | ||
|
|
||
| b, err := os.ReadFile(subscriberPositionFile) |
There was a problem hiding this comment.
Should we also check that backup directory is gone?
And that new writes are accepted by badger after DB was recreated?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation/summary
Alternative to #15081
Workaround for cases where apm-server is stuck at storage limit exceeded state indefinitely because badger DB compaction conditions are not satisfied. This PR implements a goroutine that detects this state, and if the state persists for at least TTL time, as the entries in badger DB would have been expired, just drop and recreate the DB to get out of this state.
Checklist
For functional changes, consider:
How to test these changes
Related issues
Fixes #14923