Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libbeat/docs: add item for cache processor #36785

Merged
merged 1 commit into from
Oct 9, 2023
Merged

libbeat/docs: add item for cache processor #36785

merged 1 commit into from
Oct 9, 2023

Conversation

efd6
Copy link
Contributor

@efd6 efd6 commented Oct 6, 2023

Proposed commit message

See title.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Use cases

Screenshots

Logs

@efd6 efd6 self-assigned this Oct 6, 2023
@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Oct 6, 2023
@efd6 efd6 added 8.12-candidate backport-v8.11.0 Automated backport with mergify labels Oct 6, 2023
@elasticmachine
Copy link
Collaborator

elasticmachine commented Oct 6, 2023 •
edited by jenkins-beats-ci bot
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Duration: 9 min 35 sec

❕ Flaky test report

No test was executed to be analysed.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@efd6 efd6 marked this pull request as ready for review October 6, 2023 20:50
@efd6 efd6 requested review from a team as code owners October 6, 2023 20:50
@efd6 efd6 requested review from rdner and leehinman October 6, 2023 20:50
@elasticmachine
Copy link
Collaborator

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@efd6 efd6 enabled auto-merge (squash) October 6, 2023 20:52
kilfoyle
kilfoyle approved these changes Oct 6, 2023
View reviewed changes
Copy link
Contributor

@kilfoyle kilfoyle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! The "Add cached metadata" page shows up nicely.
https://beats_36785.docs-preview.app.elstc.co/guide/en/beats/filebeat/master/add-cached-metadata.html

@pierrehilbert pierrehilbert added the Team:Elastic-Agent Label for the Agent team label Oct 8, 2023
emilioalvap
emilioalvap approved these changes Oct 9, 2023
View reviewed changes
Copy link
Collaborator

@emilioalvap emilioalvap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for uptime.

leehinman
leehinman approved these changes Oct 9, 2023
View reviewed changes
Copy link
Contributor

@leehinman leehinman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@efd6 efd6 merged commit a4f8aa1 into elastic:main Oct 9, 2023
19 checks passed
@mergify mergify bot mentioned this pull request Oct 9, 2023
Merged
mergify bot pushed a commit that referenced this pull request Oct 9, 2023
@efd6 @mergify
libbeat/docs: add item for cache processor (#36785)
230ed9c 
(cherry picked from commit a4f8aa1)
efd6 added a commit that referenced this pull request Oct 9, 2023
@mergify @efd6
libbeat/docs: add item for cache processor (#36785) (#36807)
0b75608 
(cherry picked from commit a4f8aa1)

Co-authored-by: Dan Kortschak <90160302+efd6@users.noreply.github.com>
Scholar-Li pushed a commit to Scholar-Li/beats that referenced this pull request Feb 5, 2024
@efd6 @Scholar-Li
libbeat/docs: add item for cache processor (elastic#36785)
9369283
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emilioalvap emilioalvap emilioalvap approved these changes

@leehinman leehinman leehinman approved these changes

@kilfoyle kilfoyle kilfoyle approved these changes

@andrewkroh andrewkroh andrewkroh approved these changes

@rdner rdner Awaiting requested review from rdner rdner is a code owner automatically assigned from elastic/elastic-agent-data-plane

Assignees

@efd6 efd6

Labels
8.12-candidate backport-v8.11.0 Automated backport with mergify docs libbeat Team:Elastic-Agent Label for the Agent team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@efd6 @elasticmachine @andrewkroh @kilfoyle @leehinman @emilioalvap @pierrehilbert