Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.17](backport #41932) [azure-eventhub] Make the azure-eventhub input v1 tracer opt-in #41943

Merged
merged 1 commit into from
Dec 6, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Dec 6, 2024

Proposed commit message

Make the azure-eventhub input v1 internal logs tracer opt-in. To enable internal (legacy) Event Hub SDK logs, now you need to set the following environment variable:

BEATS_AZURE_EVENTHUB_INPUT_TRACING_ENABLED: true

Before this change, the tracer was enabled by default.

A few customers reported higher than anticipated error logs in edge cases. These error logs are an essential signal to troubleshoot the root cause of several issues. However, we should give the option to completely opt out from the internal logs tracing when needed.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Disruptive User Impact

Author's Checklist

  • Write a KB article that describes how to enable and what you get
  • Add the environment variable to the input docs

How to test this PR locally

Related issues


This is an automatic backport of pull request #41932 done by [Mergify](https://mergify.com).

Make the `azure-eventhub` input v1 internal logs tracer opt-in. To enable internal (legacy) Event Hub SDK logs, now you need to set the following environment variable:

```sh
BEATS_AZURE_EVENTHUB_INPUT_TRACING_ENABLED: true
```

Before this change, the tracer was enabled by default.

A few customers reported higher than anticipated error logs in edge cases. These error logs are an essential signal to troubleshoot the root cause of several issues. However, we should give the option to completely opt out from the internal logs tracing when needed.

(cherry picked from commit 3b5823f)
@mergify mergify bot added the backport label Dec 6, 2024
@mergify mergify bot requested a review from a team as a code owner December 6, 2024 19:23
@mergify mergify bot assigned zmoog Dec 6, 2024
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Dec 6, 2024
Copy link
Contributor

@Kavindu-Dodan Kavindu-Dodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM from code owner point of view

@zmoog feel free to merge when builds are green :)

@Kavindu-Dodan Kavindu-Dodan added the Team:obs-ds-hosted-services Label for the Observability Hosted Services team label Dec 6, 2024
@elasticmachine
Copy link
Collaborator

Pinging @elastic/obs-ds-hosted-services (Team:obs-ds-hosted-services)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Dec 6, 2024
@Kavindu-Dodan Kavindu-Dodan removed the needs_team Indicates that the issue/PR needs a Team:* label label Dec 6, 2024
@zmoog zmoog merged commit cd2d8ab into 8.17 Dec 6, 2024
22 checks passed
@zmoog zmoog deleted the mergify/bp/8.17/pr-41932 branch December 6, 2024 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Team:obs-ds-hosted-services Label for the Observability Hosted Services team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants