Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.x](backport #42062) refactor: drop ensurewriter wrapper #42174

Merged
merged 1 commit into from
Dec 29, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Dec 29, 2024

Proposed commit message

stdlib properly handles EAGAIN and EINTR so there is no need for the extra wrapper and duplicate handling

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Disruptive User Impact

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Use cases

Screenshots

Logs


This is an automatic backport of pull request #42062 done by [Mergify](https://mergify.com).

* refactor: drop ensurewriter wrapper

stdlib properly handles EAGAIN and EINTR so there is no
need for the extra wrapper and duplicate handling

* Update util.go

* Update util.go

* Update util.go

* Update util.go

(cherry picked from commit 95a32ed)
@mergify mergify bot added the backport label Dec 29, 2024
@mergify mergify bot requested a review from a team as a code owner December 29, 2024 02:27
@mergify mergify bot requested review from mauri870 and khushijain21 and removed request for a team December 29, 2024 02:27
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Dec 29, 2024
@botelastic
Copy link

botelastic bot commented Dec 29, 2024

This pull request doesn't have a Team:<team> label.

@kruskall kruskall merged commit 614e060 into 8.x Dec 29, 2024
141 checks passed
@kruskall kruskall deleted the mergify/bp/8.x/pr-42062 branch December 29, 2024 04:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport needs_team Indicates that the issue/PR needs a Team:* label
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant