Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

actions: use go-version-file: .go-version #558

Merged
merged 1 commit into from
Nov 30, 2022
Merged

actions: use go-version-file: .go-version #558

merged 1 commit into from
Nov 30, 2022
+5 −10

Conversation

v1v
Copy link
Member

@v1v v1v commented Nov 30, 2022

What does this PR do?

Use the setup-go action with the go-version-file input so it reads the file .go-version

Why is it important?

Avoid the logic to read and create env variables and use the undocumented .go-version-file

See actions/setup-go#295

@v1v v1v requested a review from a team as a code owner November 30, 2022 11:05
@v1v v1v requested a review from gurevichdmitry November 30, 2022 11:05
@mergify
Copy link

mergify bot commented Nov 30, 2022

This pull request does not have a backport label. Could you fix it @v1v? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v./d./d./d is the label to automatically backport to the 8./d branch. /d is the digit
    NOTE: backport-skip has been added to this pull request.

@mergify mergify bot assigned v1v Nov 30, 2022
oren-zohar
oren-zohar approved these changes Nov 30, 2022
View reviewed changes
Copy link
Collaborator

@oren-zohar oren-zohar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@v1v v1v added backport-v8.5.0 backport pr to 8.5 branch backport-v8.6.0 and removed backport-skip labels Nov 30, 2022
@github-actions
Copy link

Cloudbeat CI 🤖

Allure Report: http://csp-allure-reports.s3.amazonaws.com/allure_reports/cloudbeat/prs/558/index.html

@oren-zohar oren-zohar merged commit b2234cc into elastic:main Nov 30, 2022
mergify bot pushed a commit that referenced this pull request Nov 30, 2022
@v1v @mergify
actions: use go-version-file: .go-version (#558)
760b962 
(cherry picked from commit b2234cc)
@mergify mergify bot mentioned this pull request Nov 30, 2022
Merged
mergify bot pushed a commit that referenced this pull request Nov 30, 2022
@v1v @mergify
actions: use go-version-file: .go-version (#558)
c0a8548 
(cherry picked from commit b2234cc)
@mergify mergify bot mentioned this pull request Nov 30, 2022
Merged
oren-zohar pushed a commit that referenced this pull request Nov 30, 2022
@mergify @v1v
[8.5](backport #558) actions: use go-version-file: .go-version (#559)
6593f58 
actions: use go-version-file: .go-version (#558)

(cherry picked from commit b2234cc)

Co-authored-by: Victor Martinez <victormartinezrubio@gmail.com>
oren-zohar pushed a commit that referenced this pull request Nov 30, 2022
@mergify @v1v
[8.6](backport #558) actions: use go-version-file: .go-version (#560)
eb55751 
actions: use go-version-file: .go-version (#558)

(cherry picked from commit b2234cc)

Co-authored-by: Victor Martinez <victormartinezrubio@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oren-zohar oren-zohar oren-zohar approved these changes

@gurevichdmitry gurevichdmitry Awaiting requested review from gurevichdmitry gurevichdmitry was automatically assigned from elastic/csp-ops

Assignees

@v1v v1v

Labels
backport-v8.5.0 backport pr to 8.5 branch backport-v8.6.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@v1v @oren-zohar