Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

actions: use go-version-file: .go-version #1841

Merged
merged 1 commit into from
Nov 30, 2022

Conversation

v1v
Copy link
Member

@v1v v1v commented Nov 30, 2022

What does this PR do?

Use the setup-go action with the go-version-file input so it reads the file .go-version

Why is it important?

Avoid the logic to read and create env variables and use the undocumented .go-version-file

See actions/setup-go#295

@v1v v1v requested a review from a team as a code owner November 30, 2022 10:56
@v1v v1v requested review from AndersonQ and michel-laterman and removed request for a team November 30, 2022 10:56
@v1v v1v added backport-v8.5.0 Automated backport with mergify backport-v8.6.0 Automated backport with mergify labels Nov 30, 2022
@v1v v1v self-assigned this Nov 30, 2022
@v1v v1v requested review from a team November 30, 2022 10:57
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-11-30T10:56:17.225+0000

  • Duration: 17 min 5 sec

Test stats 🧪

Test Results
Failed 0
Passed 4617
Skipped 13
Total 4630

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages.

  • run integration tests : Run the Elastic Agent Integration tests.

  • run end-to-end tests : Generate the packages and run the E2E Tests.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@elasticmachine
Copy link
Contributor

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 98.333% (59/60) 👍
Files 69.082% (143/207) 👍
Classes 69.133% (271/392) 👍
Methods 53.8% (814/1513) 👍
Lines 39.002% (8797/22555) 👍 0.013
Conditionals 100.0% (0/0) 💚

@v1v v1v merged commit 3d8e3c7 into elastic:main Nov 30, 2022
mergify bot pushed a commit that referenced this pull request Nov 30, 2022
mergify bot pushed a commit that referenced this pull request Nov 30, 2022
v1v added a commit that referenced this pull request Nov 30, 2022
see actions/setup-go#295

(cherry picked from commit 3d8e3c7)

Co-authored-by: Victor Martinez <victormartinezrubio@gmail.com>
v1v added a commit that referenced this pull request Nov 30, 2022
see actions/setup-go#295

(cherry picked from commit 3d8e3c7)

Co-authored-by: Victor Martinez <victormartinezrubio@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-v8.5.0 Automated backport with mergify backport-v8.6.0 Automated backport with mergify skip-changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants