Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

actions: use go-version-file: .go-version #2142

Merged
merged 1 commit into from
Nov 30, 2022

Conversation

v1v
Copy link
Member

@v1v v1v commented Nov 30, 2022

What does this PR do?

Use the setup-go action with the go-version-file input so it reads the file .go-version

Why is it important?

Avoid the logic to read and create env variables and use the undocumented .go-version-file

See actions/setup-go#295

@v1v v1v requested a review from a team November 30, 2022 10:59
@v1v v1v self-assigned this Nov 30, 2022
@v1v v1v requested review from a team as code owners November 30, 2022 10:59
@v1v v1v added backport-7.17 Automated backport to the 7.17 branch with mergify backport-v8.5.0 Automated backport with mergify backport-v8.6.0 Automated backport with mergify labels Nov 30, 2022
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-11-30T10:59:22.248+0000

  • Duration: 12 min 22 sec

Test stats 🧪

Test Results
Failed 0
Passed 393
Skipped 1
Total 394

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@v1v v1v merged commit cf5c762 into elastic:main Nov 30, 2022
mergify bot pushed a commit that referenced this pull request Nov 30, 2022
see actions/setup-go#295

(cherry picked from commit cf5c762)

# Conflicts:
#	.github/workflows/golangci-lint.yml
mergify bot pushed a commit that referenced this pull request Nov 30, 2022
mergify bot pushed a commit that referenced this pull request Nov 30, 2022
v1v added a commit that referenced this pull request Nov 30, 2022
see actions/setup-go#295

(cherry picked from commit cf5c762)

Co-authored-by: Victor Martinez <victormartinezrubio@gmail.com>
v1v added a commit that referenced this pull request Nov 30, 2022
see actions/setup-go#295

(cherry picked from commit cf5c762)

Co-authored-by: Victor Martinez <victormartinezrubio@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-7.17 Automated backport to the 7.17 branch with mergify backport-v8.5.0 Automated backport with mergify backport-v8.6.0 Automated backport with mergify
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants