chore: specify packageManager in package.json
#3359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erickzhao
force-pushed
the
chore/package-manager-corepack
branch
from
7f92a43 to
9679667
Compare
erickzhao
commented
Sep 20, 2023
| @@ -174,6 +174,7 @@ | |||
| "prettier": { | |||
| "singleQuote": true | |||
| }, | |||
| "packageManager": "yarn@1.22.18+sha1.4ba7fc5c6e704fce2066ecbfb0b0d8976fe62447", | |||
There was a problem hiding this comment.
sha1 hash grabbed from npm show yarn@1.22.19 (ref nodejs/corepack#231)
There was a problem hiding this comment.
@erickzhao, just realized this lists 1.22.18 but the SHA is for 1.22.19 - is that going to cause a problem?
BlackHole1
approved these changes
Sep 27, 2023
VerteDinde
approved these changes
Oct 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For folks using the Corepack feature in Node.js,
packageManagerspecifies which package manager version to use. Not sure if we want to land this right away since the feature isn't marked as stable in Node.js yet, but people using Corepack with the--activate(global fallback version) flag might be installing the wrong version of Yarn.ref #3357 (comment)
Note: this feature is still marked as experimental. See nodejs/corepack#104 for discussion of stability.