Load notifications without blocking #241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tintou
reviewed
Mar 6, 2022
|
Using an Idle loop instead of a thread results in a noticeable delay in the wingpanel indicators appearing (ca 1 second on my machine with 1000 notifications) but this is still a lot faster than previously. |
|
I don't think that we can really address the issue with GTK3, we need GTK4 for very large lists |
|
Maybe we should prompt the user to clear some notifications if the number gets unreasonably large? Or automatically dismiss the oldest ones. |
jeremypw
changed the title
# Conflicts fixed in: # src/Indicator.vala # src/Services/Session.vala
|
@tintou Do you think this PR is enough of an improvement to merge for now and iterate later? |
danirabbit
approved these changes
Jun 8, 2022
This was referenced Apr 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially addresses #237
Partially address #123
This PR greatly improves the load speed of the wingpanel when there are thousands of sessions notifications. The wingpanel's appearance is no longer blocked while the notification listbox is filled with entries. The notification session file is no longer needlessly rewritten. A faster function for counting the number of session notifications is provided. The function for getting a list of session notifications is sped up.
The session notifications are added to the listbox asynchronously.
A spinner shows while the session notifications are being loaded.
This only addresses loading issues. The popover is still sluggish to appear when it contains >1000 notifications.
It is noted that each NotificationEntry is a complex widget so this limits the speed they can be constructed and displayed.