Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sweep animation #283

Merged
merged 5 commits into from
Oct 9, 2024
Merged

Add sweep animation #283

merged 5 commits into from
Oct 9, 2024

Conversation

alainm23
Copy link
Contributor

@alainm23 alainm23 commented Oct 9, 2024

Just details, a sweep animation is added when clicking the clear button

2024-10-09-17.37.49.734289178.mp4

@alainm23 alainm23 requested a review from a team October 9, 2024 17:41
Copy link
Member

@danirabbit danirabbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is such a cute idea. I love this. Added a few suggestions

src/Widgets/AppEntry.vala Outdated Show resolved Hide resolved
data/AppEntryClear.css Outdated Show resolved Hide resolved
data/AppEntryClear.css Outdated Show resolved Hide resolved
src/Widgets/AppEntry.vala Outdated Show resolved Hide resolved
@alainm23
Copy link
Contributor Author

alainm23 commented Oct 9, 2024

I made the above adjustments, and also unified the stylesheets for the AppEntry widget.

@alainm23 alainm23 requested a review from danirabbit October 9, 2024 22:15
src/Widgets/AppEntry.vala Outdated Show resolved Hide resolved
src/Widgets/AppEntry.vala Show resolved Hide resolved
@alainm23 alainm23 requested a review from danirabbit October 9, 2024 22:59
Copy link
Member

@danirabbit danirabbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it, super cute! nice work :)

@danirabbit danirabbit merged commit 05f569c into master Oct 9, 2024
4 checks passed
@danirabbit danirabbit deleted the feat/sweep-animation branch October 9, 2024 23:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants