Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Support for custom attributes #180

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

Avinash-Kamath
Copy link

@Avinash-Kamath Avinash-Kamath commented Dec 9, 2024

Issue

IDP like OKTA, Azure support custom attributes along with scim attributes. Today Resource type validations will drop all non-scim compliant attributes during validation

Solution

Adding a flag to allow non-SCIM compliant attributes, updating the validation logic to include these attributes

Support for custom attributes:

  • resource_type.go: Added AllowNonScimKeys flag to ResourceType to allow non-SCIM compliant attributes. Updated the validate method to include these attributes in the resource type. [1] [2]

Testing enhancements:

  • handlers_test.go: Added the AllowNonScimKeys flag to the newTestServer function and created a new test TestServerResourceHandlerWithCustomAttributes to verify the handling of custom attributes. [1] [2]
  • utils_test.go: Added a helper function assertEqualMaps to compare maps in tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant