-
Notifications
You must be signed in to change notification settings - Fork 344
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow users to include ssl_sa_certs via env vars for kfp_tekton client #3150
Conversation
This only allows for one global cert path, should we actually add a config on the runtime metadata to allow passing this on the UI per server? |
Is the idea that a site could target multiple KFP clusters (e.g., dev, test, and production) where the "valid" certs vary from target to target? This makes sense, although I don't recall what the overhead is to extend runtime configurations with an optional property. Does this require UI work or is that portion dynamic? |
@lresende @kevin-bates thanks for the comments With this my idea, was the simply provide a way for user with unsecured cluster to utilize the feature of elyra pipeline , with a simple env var set. |
91fbece
to
46c931b
Compare
Nice work, I like this current proposed no-frills way |
46c931b
to
1018baa
Compare
LGTM, could you also provide a little update to the docs mentioning the var so that other users can leverage it. |
1018baa
to
b9651c5
Compare
- with documentation update. Signed-off-by: Harshad Reddy Nalla <hnalla@redhat.com>
b9651c5
to
b80e369
Compare
@lresende , sorry totally missed this PR. |
What changes were proposed in this pull request?
As the pipeline editor fails to connect to an unsecured pipeline server due to a certs issue, this PR includes an environment variable that can be pointed to the ssl_cert, which would be used for setting up the connection.
KF_PIPELINES_SSL_SA_CERTS
can be set with cert path.and
ssl_ca_cert
var would be set with the value and passed to kfp SDK.Fixes: #3149
How was this pull request tested?
Developer's Certificate of Origin 1.1