Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Chore/make consumer #417

Closed

Conversation

runspired
Copy link

This PR converts liquid-fire into an addon shell around liquid-fire-core and liquid-fire-velocity.

  • Remove code and tests now supplied by the other addons
  • Add a blueprint to install the new addons when installing liquid-fire
  • Trim dependencies that were only needed by removed code
  • Release the new addons
  • Consume the new addons as dependencies for the demo site and testing
  • Move Open PRs here to being against the appropriate new project
  • Update README

Unresolved Questions

  • Should the demo app stay a part of this repo (currently think yes)
  • Should explode be supplied here, in core, in velocity, or in another project (liquid-fire-helpers)
  • Should we / can we port issues to other projects where they belong

@runspired
Copy link
Author

Related PRs for Tracking:

@ef4
Copy link
Collaborator

ef4 commented Jan 15, 2016

I'm not too hung up on where people file issues, it's fine if they all end up here by default, except in cases where the user digs deeper and identifies a specific repo.

Add a blueprint to install the new addons when installing liquid-fire

I don't think we need a blueprint, just an npm dependency from liquid-fire to liquid-fire-core and liquid-fire-velocity.

Should explode be supplied here, in core, in velocity, or in another project (liquid-fire-helpers)

I think in core, since it's generally useful library code that's not dependent on any specific animation library.

@ef4 ef4 closed this Apr 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants