Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing files to --addon-only output #230

Merged
merged 1 commit into from
Nov 23, 2023
Merged

Add missing files to --addon-only output #230

merged 1 commit into from
Nov 23, 2023

Conversation

lolmaus
Copy link
Contributor

@lolmaus lolmaus commented Nov 21, 2023

image

@NullVoxPopuli
Copy link
Collaborator

Thanks for submitting!

Unfortunately everything is blocked until we figure out whot's wrong with ember-cli 5.4, #223

If you want to take over that pr, that'd be much appreciated

@lolmaus lolmaus force-pushed the addon-only-fix branch 2 times, most recently from 18e5f58 to 5c02dd0 Compare November 21, 2023 14:23
@NullVoxPopuli
Copy link
Collaborator

Ci is fixed! can you rebase? 🥳

mansona
mansona approved these changes Nov 23, 2023
View reviewed changes
Copy link
Member

@mansona mansona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 🎉

@mansona mansona merged commit 76487f6 into embroider-build:main Nov 23, 2023
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mansona mansona mansona approved these changes

Assignees

@lolmaus lolmaus

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lolmaus @NullVoxPopuli @mansona