Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding deno version #581

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Conversation

bsene
Copy link

@bsene bsene commented Dec 29, 2024

READ ME BEFORE SUBMITTING A PR

Please do not submit a PR with your solution to the Gilded Rose Kata. This repo is intended to be used as a starting point for the kata.

  • I acknowledge that this PR is not a solution to the Gilded Rose Kata, but an improvement to the template.
  • I acknowledge that I have read CONTRIBUTING.md

Please provide your PR description below this line

As stated on PR title I just added a starting point for Deno JS/TS runtime, hope it will be useful to practise within it.

@codecop
Copy link
Collaborator

codecop commented Dec 29, 2024

Please rename the folder to language-testingframework, so I guess TypeScript-deno

@bsene
Copy link
Author

bsene commented Dec 29, 2024

Np I renamed the folder

@codecop
Copy link
Collaborator

codecop commented Dec 30, 2024

Thank you. Do we still need package.json? Also I see a reference to main.ts in deno file that does not exist

@bsene
Copy link
Author

bsene commented Dec 30, 2024

No (I missed it), package.json is not necessary for Deno runtime (although it could understand it).

I remove the generated "task" with the (deleted) main entry point

@codecop
Copy link
Collaborator

codecop commented Jan 2, 2025

Thank you for staying with me. There is a typo in the readme though ´deo test --watch`. Else this looks good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants