Rename system library files from library_foo.js to libfoo.js #23348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
At the same time move all the libraries file into a separate `lib/src` directory. This helps to distinguish library files from other files in the `lib` directory, which was very overcrowed. These files were also includable via `-lfoo` and we had a special case for system libraries where `library_foo.js` could be used in addition to `libfoo.js`. This change removes to special case. This only file that was not renamed using the simple pattern was `library.py` itself which becomes `libcore.py`. I also considered `libemscripten.js`. To some this may seem like needless churn but for years now I've been wanting to cleanup the `src` directory. I think have files logically separated into directories helps a lot with understanding the project structure. As a followup I am also considering moving all the runtime files into `src/include` (since these are all files that get `#included` into the generated code directly. That would leave the `src` directory containing only the JS compiler code itself which I think is another important distinction.
|
Marking as draft for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the same time move all the libraries file into a separate
lib/srcdirectory. This helps to distinguish library files from other files in thelibdirectory, which was very overcrowed.These files were also includable via
-lfooand we had a special case for system libraries wherelibrary_foo.jscould be used in addition tolibfoo.js. This change removes to special case.This only file that was not renamed using the simple pattern was
library.pyitself which becomeslibcore.py. I also consideredlibemscripten.js.To some this may seem like needless churn but for years now I've been wanting to cleanup the
srcdirectory. I think have files logically separated into directories helps a lot with understanding the project structure.As a followup I am also considering moving all the runtime files into
src/include(since these are all files that get#includedinto the generated code directly. That would leave thesrcdirectory containing only the JS compiler code itself which I think is another important distinction.