Enable eslint no-undef rule in JS compiler. NFC
#23384
Merged
+30
−59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbc100
force-pushed
the
eslint_improve
branch
7 times, most recently
from
2a0ffda to
5c555b9
Compare
kripken
approved these changes
Jan 14, 2025
This required making eslint aware of the settings globals which are used throughout the compiler. Running this change revealed several legacy parseTools function that simply do run due to references to undefined symbols (because of this we know that there are not active/current user of these legacy function).
sbc100
force-pushed
the
eslint_improve
branch
from
5c555b9 to
ff9b0df
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This required making eslint aware of the settings globals which are used throughout the compiler.
Running this change revealed several legacy parseTools function that simply do not run due to references to undefined symbols (because of this we know that there are no active/current user of these functions).