Skip to content

Commit

Permalink
Remove lang item related TODOs
Browse files Browse the repository at this point in the history
  • Loading branch information
davidsemakula committed Jan 1, 2025
1 parent 46944ed commit 62c5570
Showing 1 changed file with 0 additions and 4 deletions.
4 changes: 0 additions & 4 deletions checker/src/known_names.rs
Original file line number Diff line number Diff line change
Expand Up @@ -279,7 +279,6 @@ fn known_name_for_std_lib(path_segments: &[DisambiguatedDefPathData]) -> Option<
"marker" => known_name_for_terminal_from_ns!(
tail_segments,
DefPathData::TypeNs,
// TODO: (@davidsemakula) Remove in favor of lang item?
"PhantomData",
KnownNames::StdMarkerPhantomData
),
Expand Down Expand Up @@ -319,7 +318,6 @@ fn get_known_name_for_alloc_namespace(
}
}

// TODO: (@davidsemakula) Remove in favor of lang item?
fn get_known_name_for_clone_namespace(
path_segments: &[DisambiguatedDefPathData],
) -> Option<KnownNames> {
Expand Down Expand Up @@ -472,7 +470,6 @@ fn known_name_for_intrinsics_namespace(
}

fn known_name_for_ops_namespace(path_segments: &[DisambiguatedDefPathData]) -> Option<KnownNames> {
// TODO: (@davidsemakula) Handle as assoc lang items?
// TODO: (@davidsemakula) was `call_once_force` removed,
// or did it actually resolve to a different (perhaps nested) path before?
// See https://github.com/endorlabs/MIRAI/issues/26#issuecomment-2566638406 for details.
Expand All @@ -494,7 +491,6 @@ fn known_name_for_ops_namespace(path_segments: &[DisambiguatedDefPathData]) -> O
}
}

// TODO: (@davidsemakula) Remove in favor of lang items (where possible)?
fn known_name_for_panicking_namespace(
path_segments: &[DisambiguatedDefPathData],
) -> Option<KnownNames> {
Expand Down

0 comments on commit 62c5570

Please sign in to comment.