Improve Client Side Weighted Round Robin lb policy. #37127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Track whether `updateWeightsOnHosts()` changes any host weights and `applyWeightsToAllWorkers()` if necessary. - Use thread local storage to track callbacks to worker-local load balancers and use `runOnAllThreads` to refresh them to apply the new weights. - Update weights on hosts when new hosts are added, so they get reasonable initial weight. - Calculate median weight of even number of valid hosts as an average of two weights closest to the median. Signed-off-by: Misha Efimov <mef@google.com>
Signed-off-by: Misha Efimov <mef@google.com>
adisuissa
reviewed
Nov 18, 2024
test/extensions/load_balancing_policies/client_side_weighted_round_robin/integration_test.cc
Show resolved
Hide resolved
...d_balancing_policies/client_side_weighted_round_robin/client_side_weighted_round_robin_lb.cc
Outdated
Show resolved
Hide resolved
...d_balancing_policies/client_side_weighted_round_robin/client_side_weighted_round_robin_lb.cc
Outdated
Show resolved
Hide resolved
...d_balancing_policies/client_side_weighted_round_robin/client_side_weighted_round_robin_lb.cc
Outdated
Show resolved
Hide resolved
...d_balancing_policies/client_side_weighted_round_robin/client_side_weighted_round_robin_lb.cc
Outdated
Show resolved
Hide resolved
wbpcode
reviewed
Nov 19, 2024
...ad_balancing_policies/client_side_weighted_round_robin/client_side_weighted_round_robin_lb.h
Outdated
Show resolved
Hide resolved
|
The code change is LGTM overall. Thanks for the update. Only one comment is added. |
Signed-off-by: Misha Efimov <mef@google.com>
Signed-off-by: Misha Efimov <mef@google.com>
efimki
commented
Nov 19, 2024
...d_balancing_policies/client_side_weighted_round_robin/client_side_weighted_round_robin_lb.cc
Outdated
Show resolved
Hide resolved
...d_balancing_policies/client_side_weighted_round_robin/client_side_weighted_round_robin_lb.cc
Outdated
Show resolved
Hide resolved
...d_balancing_policies/client_side_weighted_round_robin/client_side_weighted_round_robin_lb.cc
Outdated
Show resolved
Hide resolved
...ad_balancing_policies/client_side_weighted_round_robin/client_side_weighted_round_robin_lb.h
Outdated
Show resolved
Hide resolved
test/extensions/load_balancing_policies/client_side_weighted_round_robin/integration_test.cc
Show resolved
Hide resolved
Signed-off-by: Misha Efimov <mef@google.com>
|
/retest |
|
Please merge the main and resolve the conflicts. Than we can land this. |
Signed-off-by: Misha Efimov <mef@google.com>
|
Done, PTAL. |
wbpcode
approved these changes
Nov 21, 2024
|
cc @adisuissa to merge because @adisuissa have proposed more great suggestions. |
I think they were addressed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
updateWeightsOnHosts()changes any host weights andapplyWeightsToAllWorkers()if necessary.runOnAllThreadsto refresh them to apply the new weights.Risk Level: Low
Testing: bazel test //test/extensions/load_balancing_policies/client_side_weighted_round_robin/...
#34777