Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clang-tidy: ignore value_or used in optref helper #37379

Merged
merged 1 commit into from
Nov 27, 2024

clang-tidy: ignore value_or used in optref helper

d64fb32
Select commit
Loading
Failed to load commit list.
Merged

clang-tidy: ignore value_or used in optref helper #37379

clang-tidy: ignore value_or used in optref helper
d64fb32
Select commit
Loading
Failed to load commit list.
CI (Envoy) / Mobile/iOS tests skipped Nov 26, 2024 in 0s

Check was skipped

This check was not triggered in this CI run

Details

Request (pr/37379/main@d64fb32)

mathetake @mathetake d64fb32 #37379 merge main@b1a2af6

clang-tidy: ignore value_or used in optref helper

This adds value_or to the ignore-list of naming convention.
The similar has_value was already in the list and both are to
be aligned with their absl::optional counterparts.

part of #28566

cc @phlax

Environment

Request variables

Key Value
ref e7848d5
sha d64fb32
pr 37379
base-sha b1a2af6
actor mathetake @mathetake
message clang-tidy: ignore value_or used in optref helper...
started 1732649204.854857
target-branch main
trusted false
Build image

Container image/s (as used in this CI run)

Key Value
default envoyproxy/envoy-build-ubuntu:f94a38f62220a2b017878b790b6ea98a0f6c5f9c
mobile envoyproxy/envoy-build-ubuntu:mobile-f94a38f62220a2b017878b790b6ea98a0f6c5f9c
Version

Envoy version (as used in this CI run)

Key Value
major 1
minor 33
patch 0
dev true
View more details on CI (Envoy)