Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci/clang-tidy: make CLANG_TIDY_TARGETS configurable #37428

Merged
merged 4 commits into from
Nov 29, 2024
Merged

ci/clang-tidy: make CLANG_TIDY_TARGETS configurable #37428

merged 4 commits into from
Nov 29, 2024

Conversation

mathetake
Copy link
Member

@mathetake mathetake commented Nov 29, 2024 •
edited
Loading

part of #28566

@mathetake
ci/clang-tidy: make the target configurable
fa0d5f1 
Signed-off-by: Takeshi Yoneda <t.y.mathetake@gmail.com>
@mathetake mathetake changed the title ci/clang-tidy: make the target configurable ci/clang-tidy: make CLANG_TIDY_TARGETS configurable Nov 29, 2024
phlax
phlax previously approved these changes Nov 29, 2024
View reviewed changes
Copy link
Member

@phlax phlax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks @mathetake

@phlax
Copy link
Member

phlax commented Nov 29, 2024

hmm, i wondered if shellcheck would agree

i think you have 2 options - you can either make use of $@ as suggested before - or to do what you are doing - which i think is better - then you will need to read the env var into an array

@mathetake
how about this
33c9321 
Signed-off-by: Takeshi Yoneda <t.y.mathetake@gmail.com>
phlax
phlax reviewed Nov 29, 2024
View reviewed changes
ci/do_ci.sh Outdated Show resolved Hide resolved
@mathetake @phlax
Update ci/do_ci.sh
934c9e0 
Co-authored-by: phlax <phlax@users.noreply.github.com>
Signed-off-by: Takeshi Yoneda <t.y.mathetake@gmail.com>
phlax
phlax reviewed Nov 29, 2024
View reviewed changes
ci/do_ci.sh Outdated Show resolved Hide resolved
@mathetake
this is it?
d04a689 
Signed-off-by: Takeshi Yoneda <t.y.mathetake@gmail.com>
@mathetake
Copy link
Member Author

working now

phlax
phlax approved these changes Nov 29, 2024
View reviewed changes
Copy link
Member

@phlax phlax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@phlax phlax enabled auto-merge (squash) November 29, 2024 18:45
@phlax phlax merged commit 2e80071 into envoyproxy:main Nov 29, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phlax phlax phlax approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mathetake @phlax