Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dynamic_modules: adds send response #37856

Merged
merged 17 commits into from
Jan 9, 2025

Merge branch 'main' into send-response

db1d1d2
Select commit
Loading
Failed to load commit list.
Merged

dynamic_modules: adds send response #37856

Merge branch 'main' into send-response
db1d1d2
Select commit
Loading
Failed to load commit list.
CI (Envoy) / Mobile/Release validation skipped Jan 8, 2025 in 0s

Check was skipped

This check was not triggered in this CI run

Details

Request (pr/37856/main@db1d1d2)

bplotnick @bplotnick db1d1d2 #37856 merge main@2425431

dynamic_modules: adds send response

Commit Message: Add envoy_dynamic_module_callback_http_send_response to the dynamic modules ABI and rust SDK
Additional Description: This adds the ability to send a local response back. I've also fixed up abi_impl_test.cc. Before, it was not asserting on the correct headers. Now i've moved to parameterized tests so we can assert on the correct headers and also split out the tests into smaller units.
Risk Level: low
Testing: unit tests
Docs Changes:
Release Notes:
Platform Specific Features:

Environment

Request variables

Key Value
ref c04441c
sha db1d1d2
pr 37856
base-sha 2425431
actor bplotnick @bplotnick
message dynamic_modules: adds send response...
started 1736313803.56922
target-branch main
trusted false
Build image

Container image/s (as used in this CI run)

Key Value
default envoyproxy/envoy-build-ubuntu:d2be0c198feda0c607fa33209da01bf737ef373f
mobile envoyproxy/envoy-build-ubuntu:mobile-d2be0c198feda0c607fa33209da01bf737ef373f
Version

Envoy version (as used in this CI run)

Key Value
major 1
minor 33
patch 0
dev true