Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

api: add TIMEOUT value to CSDS status enum #37871

Merged
merged 1 commit into from
Jan 6, 2025

Conversation

markdroth
Copy link
Contributor

Commit Message: api: add TIMEOUT value to CSDS status enum
Additional Description: Also remove unnecessary CLIENT_ prefix to the enum value added in #37858. For context, see grpc/proposal#466.
Risk Level: Low
Testing: N/A
Docs Changes: Included in PR
Release Notes: N/A
Platform Specific Features: N/A

CC @adisuissa

Signed-off-by: Mark D. Roth <roth@google.com>
Copy link

CC @envoyproxy/api-shepherds: Your approval is needed for changes made to (api/envoy/|docs/root/api-docs/).
envoyproxy/api-shepherds assignee is @abeyad
CC @envoyproxy/api-watchers: FYI only for changes made to (api/envoy/|docs/root/api-docs/).

🐱

Caused by: #37871 was opened by markdroth.

see: more, trace.

Copy link
Contributor

@abeyad abeyad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm api

@repokitteh-read-only repokitteh-read-only bot removed the api label Jan 4, 2025
Copy link
Contributor

@adisuissa adisuissa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@adisuissa adisuissa enabled auto-merge (squash) January 6, 2025 13:40
@adisuissa adisuissa disabled auto-merge January 6, 2025 13:40
@adisuissa adisuissa enabled auto-merge (squash) January 6, 2025 13:41
@adisuissa adisuissa merged commit 2aaa544 into envoyproxy:main Jan 6, 2025
25 checks passed
@markdroth markdroth deleted the csds_timeout_enum branch January 6, 2025 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants