docs: reword the example in the aggregate cluster docs #37872
Merged
+120
−29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Docs for this Pull Request will be rendered here: https://storage.googleapis.com/envoy-pr/37872/docs/index.html The docs are (re-)rendered each time the CI |
agrawroh
force-pushed
the
agg_cluster_docs-2
branch
2 times, most recently
from
d72e6aa to
c05d0ca
Compare
Signed-off-by: Rohit Agrawal <rohit.agrawal@databricks.com>
agrawroh
force-pushed
the
agg_cluster_docs-2
branch
from
c05d0ca to
e4a7250
Compare
phlax
reviewed
Jan 4, 2025
| priority. | ||
| The aggregate cluster load balancer first calculates each priority's health score for every cluster, sums those up, | ||
| and then assigns traffic based on the overall total. If the total is at least ``100``, the combined traffic is capped at | ||
| ``100%``. If it's below ``100``, Envoy scales (normalizes) it so that the final distribution sums to ``100%``. |
There was a problem hiding this comment.
our rules are pretty shakey on this, but i think the percentages dont want to be literals - just config settings, response codes, etc - these are actual literals rather than just numbers
There was a problem hiding this comment.
Make sense. So should we leave them as it or should I make them bold using **?
There was a problem hiding this comment.
not sure would need to look at it rendered - generally i think boldening (which i like) is mostly useful for skim reading - so if it assists that
phlax
approved these changes
Jan 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR rewords the example we have in the aggregate cluster to explain how the cluster level load balancer selects the cluster.
Rendered Docs Link
Commit Message: docs: reword the example in the aggregate cluster docs
Additional Description: Reword the example in aggregate cluster to make it more clear.
Risk Level: N/A
Testing: N/A
Docs Changes: N/A
Release Notes: N/A