ratelimit: added support for rate limiting based on query parameters #37875
+328
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CC @envoyproxy/api-shepherds: Your approval is needed for changes made to |
|
/retest |
Signed-off-by: Rohit Agrawal <rohit.agrawal@databricks.com>
agrawroh
force-pushed
the
ratelimit_query_params
branch
from
0f93a8a to
c1be1c3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently, Envoy lacks a straightforward way to create rate limit descriptors directly from query parameters. The existing
query_parameter_value_matchaction focuses on matching query parameter values, but does not provide a simple mechanism to generate descriptors.This PR introduces a new
query_parametersrate limit action that allows generating rate limit descriptors based on query parameter values.Fixes: #37657
Commit Message: ratelimit: added support for rate limiting based on query parameters
Additional Description:
Risk Level: Low
Testing: Added Unit Tests
Docs Changes: Added
Release Notes: Added