Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix typos in the current changelogs #37879

Merged
merged 3 commits into from
Jan 6, 2025

Conversation

agrawroh
Copy link
Contributor

@agrawroh agrawroh commented Jan 5, 2025

Description

This PR fixes some small typo in the change-logs. Some of the entries are not getting rendered properly due to missing backticks, etc.

For example,
Screenshot 2025-01-06 at 00 22 15


Commit Message: docs: fix typos in the current changelogs
Additional Description: Fixes some small typo in the change-logs to render the entries properly.
Risk Level: N/A
Testing: N/A
Docs Changes: N/A
Release Notes: N/A

Copy link

Docs for this Pull Request will be rendered here:

https://storage.googleapis.com/envoy-pr/37879/docs/index.html

The docs are (re-)rendered each time the CI envoy-presubmit (precheck docs) job completes.

🐱

Caused by: #37879 was opened by agrawroh.

see: more, trace.

@agrawroh agrawroh force-pushed the changelogs_fix branch 2 times, most recently from ce6c440 to 990b5f7 Compare January 5, 2025 23:32
Signed-off-by: Rohit Agrawal <rohit.agrawal@databricks.com>
@agrawroh
Copy link
Contributor Author

agrawroh commented Jan 6, 2025

/retest

changelogs/current.yaml Outdated Show resolved Hide resolved
changelogs/current.yaml Outdated Show resolved Hide resolved
changelogs/current.yaml Outdated Show resolved Hide resolved
agrawroh and others added 2 commits January 6, 2025 03:34
Signed-off-by: Rohit Agrawal <rohit.agrawal@databricks.com>
Co-authored-by: phlax <phlax@users.noreply.github.com>
Signed-off-by: Rohit Agrawal <rohit.agrawal@databricks.com>
@agrawroh agrawroh requested a review from phlax January 6, 2025 11:35
Copy link
Member

@phlax phlax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks @agrawroh

@phlax phlax merged commit aeb60e0 into envoyproxy:main Jan 6, 2025
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants