Skip to content

Commit

Permalink
Be explicit about not signing the Android aab
Browse files Browse the repository at this point in the history
Because the location of the android key.properties has been moved into
the secrets/ folder.
  • Loading branch information
inetic committed Oct 6, 2023
1 parent c2db1f8 commit af1c492
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 6 deletions.
5 changes: 2 additions & 3 deletions android/app/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -87,9 +87,8 @@ android {

buildTypes {
release {
if (keystorePropertiesFile.exists()) {
signingConfig signingConfigs.release
} else {
// Signing with the debug keys for now, so `flutter run --release` works.
if (System.getenv("NO_SIGN") != "true") {
signingConfig signingConfigs.debug
}
}
Expand Down
9 changes: 6 additions & 3 deletions util/release.dart
Original file line number Diff line number Diff line change
Expand Up @@ -508,7 +508,9 @@ Future<File> buildAab(BuildDesc buildDesc) async {
buildDesc.version.build[0].toString(),
'--build-name',
buildDesc.toString(),
]);
], environment: {
"NO_SIGN": "true"
});

return File(inputPath);
}
Expand Down Expand Up @@ -822,9 +824,10 @@ Future<Directory> createOutputDir(BuildDesc buildDesc) async {

Future<void> run(
String command,
List<String> args, [
List<String> args, {
String? workingDirectory,
]) async {
Map<String, String>? environment,
}) async {
final process = await Process.start(
command,
args,
Expand Down

0 comments on commit af1c492

Please sign in to comment.