fix: "device update --lock" should also unlock

Signed-off-by: Marques Johansson <mjohansson@equinix.com>
equinix · Aug 26, 2024 · 34ccdcd · 34ccdcd
1 parent b5eaed2
commit 34ccdcd
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 6 deletions.
diff --git a/docs/metal_device_update.md b/docs/metal_device_update.md
@@ -27,7 +27,7 @@ metal device update -i <device_id> [-H <hostname>] [-d <description>] [--locked
   -H, --hostname string          The new hostname of the device.
   -i, --id string                The UUID of the device.
   -s, --ipxe-script-url string   Add or update the URL of the iPXE script.
-  -l, --locked                   Locks or unlocks the device for future changes (<true|false>).
+  -l, --locked bools             Locks or unlocks the device for future changes (<true|false>). (default [])
   -t, --tags strings             Adds or updates the tags for the device --tags="tag1,tag2".
   -u, --userdata string          Adds or updates the userdata for the device.
       --userdata-file string     Path to a userdata file for device initialization. Can not be used with --userdata.

diff --git a/internal/devices/update.go b/internal/devices/update.go
@@ -34,7 +34,6 @@ import (
 func (c *Client) Update() *cobra.Command {
 	var (
 		description   string
-		locked        bool
 		userdata      string
 		userdataFile  string
 		hostname      string
@@ -80,8 +79,15 @@ func (c *Client) Update() *cobra.Command {
 				deviceUpdate.Userdata = &userdata
 			}
 
-			if locked {
-				deviceUpdate.Locked = &locked
+			if cmd.Flag("locked").Changed {
+				locked, err := cmd.Flags().GetBoolSlice("locked")
+				if err != nil {
+					return fmt.Errorf("could not parse locked value: %w", err)
+				}
+				if len(locked) > 1 {
+					return fmt.Errorf("parameter locked may only be set once")
+				}
+				deviceUpdate.Locked = &locked[0]
 			}
 
 			if len(tags) > 0 {
@@ -123,12 +129,11 @@ func (c *Client) Update() *cobra.Command {
 	updateDeviceCmd.Flags().StringVarP(&description, "description", "d", "", "Adds or updates the description for the device.")
 	updateDeviceCmd.Flags().StringVarP(&userdata, "userdata", "u", "", "Adds or updates the userdata for the device.")
 	updateDeviceCmd.Flags().StringVarP(&userdataFile, "userdata-file", "", "", "Path to a userdata file for device initialization. Can not be used with --userdata.")
-	updateDeviceCmd.Flags().BoolVarP(&locked, "locked", "l", false, "Locks or unlocks the device for future changes (<true|false>).")
+	updateDeviceCmd.Flags().BoolSliceP("locked", "l", []bool{}, "Locks or unlocks the device for future changes (<true|false>).")
 	updateDeviceCmd.Flags().StringSliceVarP(&tags, "tags", "t", []string{}, `Adds or updates the tags for the device --tags="tag1,tag2".`)
 	updateDeviceCmd.Flags().BoolVarP(&alwaysPXE, "always-pxe", "a", false, "Updates the always_pxe toggle for the device (<true|false>).")
 	updateDeviceCmd.Flags().StringVarP(&ipxescripturl, "ipxe-script-url", "s", "", "Add or update the URL of the iPXE script.")
 	updateDeviceCmd.Flags().StringVarP(&customdata, "customdata", "c", "", "Adds or updates custom data to be included with your device's metadata.")
 	_ = updateDeviceCmd.MarkFlagRequired("id")
-
 	return updateDeviceCmd
 }