Skip to content

Commit

Permalink
Update readme
Browse files Browse the repository at this point in the history
  • Loading branch information
eralpkaraduman committed Aug 21, 2021
1 parent 76b4a89 commit 6135e20
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -51,10 +51,10 @@ I added a feature which automatically adds the latest PDF version download link
This only works when automatic PDF version generation was set up (mentioned above).
This is done by javascript running on the page, it tries to fetch github's API to get the last release.
This link won't be generated in the PDF itself for several reasons;
- Lack of necessity, since you have the pdf there's need to download it again.
- I didn't want to deal with all the troubles coming with executing javascript in pdf generation context
- Travis CI blocks the request to github API i guess?
- I disabled javascript on wkhtmltopdf, see 2 reasons above.
- Lack of necessity, since you have the pdf there's no need to download it again.
- I didn't want to figure out the issues with executing javascript in pdf generation context
- ~~Travis CI blocks the request to github API i guess?~~ We don't use travis anymore, automation is moved to github actions
- I disabled javascript on wkhtmltopdf, see reasons above.


## Running jekyll locally
Expand Down

0 comments on commit 6135e20

Please sign in to comment.