Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only print anything on errors #50

Merged
merged 1 commit into from
Nov 14, 2023
Merged

Conversation

lalten
Copy link
Contributor

@lalten lalten commented Nov 14, 2023

Let's have a dark cockpit. With this change, if you have no clang-tidy issues in any file, there will not be any output.

@erenon
Copy link
Owner

erenon commented Nov 14, 2023

fmi: what's the purpose? doesn't the bazel UI hide output anyways?

@lalten
Copy link
Contributor Author

lalten commented Nov 14, 2023

fmi: what's the purpose? doesn't the bazel UI hide output anyways?

If the clang-tidy configuration causes the tool to print stuff but still exit 0, Bazel will show everything. You can try to put an echo hello in the run_clang_tidy.sh, it will be printed always

Example:

INFO: From Run clang-tidy on path/to/source.cpp:
2618 warnings generated.
Suppressed 2626 warnings (2618 in non-user code, 8 NOLINT).
Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.

@erenon erenon merged commit 327c066 into erenon:master Nov 14, 2023
1 check passed
@erenon
Copy link
Owner

erenon commented Nov 14, 2023

Thanks!

@lalten lalten deleted the quiet-on-success branch November 14, 2023 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants