Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass through --sysroot #51

Merged
merged 1 commit into from
Nov 14, 2023
Merged

Pass through --sysroot #51

merged 1 commit into from
Nov 14, 2023

Conversation

lalten
Copy link
Contributor

@lalten lalten commented Nov 14, 2023

clang-tidy supports --sysroot and in fact needs it to find header files in some cases.
For example if building with a hermetic compiler and libc++/libstdc++.

The flag was first ignored in c0d0793 but I couldn't find a reason as to why the removal was necessary.

@erenon
Copy link
Owner

erenon commented Nov 14, 2023

Thanks! The reason it was ignored to be able to run clang tidy, with only gcc setup with sysroot. If you pass a gcc sysroot to clang, bad things happen (the commit message could have been better...).
Let's try this change and see if ppl complain.

@erenon erenon merged commit 3b5aceb into erenon:master Nov 14, 2023
1 check passed
@lalten lalten deleted the pass-sysroot branch November 14, 2023 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants