Slightly optimize bit syntax construction #9225
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Having the definition in erl_bits.h allows us to use it from beam_jit_common.cpp.
bjorng
added
team:VM
CT Test Results 3 files 141 suites 48m 36s ⏱️ Results for commit aeb36f1. ♻️ This comment has been updated with latest results. To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass. See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally. Artifacts// Erlang/OTP Github Action Bot |
jhogberg
previously approved these changes
Dec 20, 2024
|
|
||
| /* This instruction is always preceded by a size calculation that | ||
| * guarantees that 'arg' is a bitstring. */ | ||
| ASSERT(is_bitstring(arg)); |
There was a problem hiding this comment.
Nitpick: this is already checked in ERTS_GET_BITSTRING.
Slightly optimize creation of binary segments when it's known that units are compatible.
When accumulating a fixed-size integer, be sure to use the smallest possible native instructions. Also simplify storing the first value into the accumulator.
bjorng
force-pushed
the
bjorn/erts/opt-bit-syntax-construction
branch
from
67ff56c to
aeb36f1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See the individual commit messages for details.