Update the code to better handle the dropdown menus #299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
User's choice will be marked with ⚫ when present |
erwindon
force-pushed
the
dropdown
branch
3 times, most recently
from
90b615f to
12df10f
Compare
erwindon
force-pushed
the
dropdown
branch
2 times, most recently
from
afb9270 to
b879cf3
Compare
erwindon
force-pushed
the
dropdown
branch
6 times, most recently
from
f265dd1 to
ed09767
Compare
erwindon
force-pushed
the
dropdown
branch
2 times, most recently
from
575dbcd to
8535af0
Compare
erwindon
force-pushed
the
dropdown
branch
3 times, most recently
from
c8d4d86 to
0e9f49e
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
erwindon
force-pushed
the
dropdown
branch
2 times, most recently
from
979beaf to
c51183b
Compare
erwindon
force-pushed
the
dropdown
branch
2 times, most recently
from
fc2226a to
54015e6
Compare
erwindon
force-pushed
the
dropdown
branch
2 times, most recently
from
de17bc4 to
8c5346b
Compare
erwindon
force-pushed
the
dropdown
branch
2 times, most recently
from
9285f31 to
41d2a54
Compare
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is your feature request related to a problem? Please describe.
The current "checkbox-button" style menu and the "radio-button" style menu's have very dirty implementations.
Both can be found in the command-box.
Describe the solution you'd like
This should be cleaned up. Best solution seems to be the introduction of a "DropDownCheckbox" and "DropDownRadio" sub-classes that handle all the specifics.
Describe alternatives you've considered
Additional context
Additionally, the difference between the user's choice and the system's choice in the "target" menu should be enhanced.
Additionally, the dropdown menu's should work on touchscreens. i.e. the menu opens on 'click' instead of only 'mouseover'.