Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

only call test.providers when results were not retrieved before #661

Closed
wants to merge 1 commit into from

Conversation

erwindon
Copy link
Owner

@erwindon erwindon commented Dec 7, 2024

general alternative for #660 (but not a replacement for it)

@erwindon
Copy link
Owner Author

erwindon commented Dec 7, 2024

@vkotarov
Can you test this PR to see whether it works also in your case?
We'll discuss further measures in #660, but this is a generic improvement.

@erwindon erwindon force-pushed the less_test_providers branch from 44876b6 to bc6c9ca Compare December 8, 2024 08:23
Copy link

sonarqubecloud bot commented Dec 8, 2024

@vkotarov
Copy link

@erwindon
The thing is that "test.providers" targeting "*" in our environment takes about 85 seconds to complete.
Also, if a user hits the refresh button for some reason, this will have to be executed again, so 85 more seconds time to wait.

@erwindon erwindon marked this pull request as ready for review December 10, 2024 20:09
@erwindon
Copy link
Owner Author

@vkotarov
I know! And that is why the work on #660 will continue. But this one is a general improvement which does not need any configuration. It is an improvement compared to any previous version and it is useful for everyone. See this as a spin-off.
Since it is related to #660, I'm asking you to please look at it and maybe test it in any environment you have available and confirm that it is suitable for the world. thx!

@erwindon erwindon assigned vkotarov and unassigned erwindon Dec 10, 2024
@erwindon erwindon closed this Dec 12, 2024
@erwindon erwindon deleted the less_test_providers branch December 12, 2024 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants