Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow alternative target for test.providers #663

Merged
merged 2 commits into from
Dec 17, 2024
Merged

Conversation

erwindon
Copy link
Owner

@erwindon erwindon commented Dec 12, 2024

alternative solution for #660

The PR comes with an updated section of the documentation.
Please read that as part of the review.

@erwindon erwindon marked this pull request as draft December 12, 2024 20:50
@erwindon erwindon self-assigned this Dec 12, 2024
@erwindon erwindon force-pushed the config_test_providers branch 2 times, most recently from 4dada28 to c3670f7 Compare December 12, 2024 21:15
@erwindon erwindon force-pushed the config_test_providers branch from c3670f7 to 19499a1 Compare December 12, 2024 21:29
@erwindon
Copy link
Owner Author

@vkotarov @dexterlb
Can you please review this solution?
Note that I cannot assign you as reviewers since (according to github) you are not involved in this PR yet.

@vkotarov
Copy link

@erwindon
This works great, as described. Will be closing #660 in favor of this one.
Thank you for your efforts!

@erwindon
Copy link
Owner Author

I'll merge this later today.

@erwindon erwindon marked this pull request as ready for review December 17, 2024 14:20
@erwindon erwindon assigned vkotarov and erwindon and unassigned erwindon and vkotarov Dec 17, 2024
@erwindon erwindon merged commit 7f09441 into master Dec 17, 2024
5 checks passed
@erwindon erwindon deleted the config_test_providers branch December 17, 2024 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants